Don't crash when providing (by mistake) a directory instead of a file. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, running: ./checktestdata <spec_file> <directory> would crash with: terminate called after throwing an instance of 'std::length_error' what(): basic_string::_M_create Aborted (core dumped) <directory> is not expected by checktestdata, and it should be a filename instead. Still, checktestdata should return an error instead of crashing.
RagnarGrootKoerkamp
approved these changes
Dec 19, 2024
|
Merged while resolving the whitespace issues in a74d332 |
|
I also removed the comments from the code as they're not that relevant there now that the issue is fixed and can also be found in the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, running:
./checktestdata <spec_file>
would crash with:
terminate called after throwing an instance of 'std::length_error'
what(): basic_string::_M_create
Aborted (core dumped)
is not expected by checktestdata, and it should be a filename instead. Still, checktestdata should return an error instead of crashing.